Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enrich attributes regardless if it is materialized #6000

Merged
merged 8 commits into from
Oct 9, 2024
Merged

fix: enrich attributes regardless if it is materialized #6000

merged 8 commits into from
Oct 9, 2024

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Sep 18, 2024 •
edited
Loading

Changes

  • If a column is selected and later it was removed, or the dashboard is copied to an instance where it is not selected one then we should enrich regardless so that the query doesn't fail.
  • Take care if the same key name is present in resource and tag or have multiple dataType.

Fixes https://github.com/SigNoz/engineering-pod/issues/1774

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Sep 18, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@nityanandagohain
Copy link
Member Author

@srikanthccv please leave your thoughts here if we should proceed with this and keep the concerns in an issue.

@srikanthccv
Copy link
Member

Please re-request a review after making the changes; otherwise, it doesn't appear on my "awaiting review from you" tab.

@nityanandagohain nityanandagohain merged commit 2230ca1 into develop Oct 9, 2024
13 checks passed
@nityanandagohain nityanandagohain deleted the issue_1774 branch October 9, 2024 14:33
@nityanandagohain nityanandagohain mentioned this pull request Oct 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nityanandagohain @srikanthccv